Skip to content

Commit

Permalink
Shutdown not respoinding websocket clients (Fixes miguelgrinberg/pyth…
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelgrinberg committed Aug 5, 2019
1 parent 0adc074 commit 95731e9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion engineio/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ def _ping_loop(self):
self.logger.info(
'PONG response has not been received, aborting')
if self.ws:
self.ws.close()
self.ws.shutdown()
self.queue.put(None)
break
self.pong_received = False
Expand Down
2 changes: 1 addition & 1 deletion tests/common/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ def fake_wait(timeout):
c._ping_loop()
self.assertEqual(c.state, 'connected')
c.queue.put.assert_called_once_with(None)
c.ws.close.assert_called_once_with()
c.ws.shutdown.assert_called_once_with()

def test_read_loop_polling_disconnected(self):
c = client.Client()
Expand Down

0 comments on commit 95731e9

Please sign in to comment.