reset sid after a disconnect

miguelgrinberg · Feb 12, 2019 · 9aa7742 · 9aa7742
1 parent 82f6982
commit 9aa7742
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/engineio/client.py b/engineio/client.py
@@ -252,6 +252,7 @@ def create_event(self, *args, **kwargs):
 
     def _reset(self):
         self.state = 'disconnected'
+        self.sid = None
 
     def _connect_polling(self, url, headers, engineio_path):
         """Establish a long-polling connection to the Engine.IO server."""

diff --git a/tests/asyncio/test_asyncio_client.py b/tests/asyncio/test_asyncio_client.py
@@ -160,8 +160,10 @@ async def fake_send_packet(pkt):
     def test_disconnect_not_connected(self):
         c = asyncio_client.AsyncClient()
         c.state = 'foo'
+        c.sid = 'bar'
         _run(c.disconnect())
         self.assertEqual(c.state, 'disconnected')
+        self.assertIsNone(c.sid)
 
     def test_disconnect_polling(self):
         c = asyncio_client.AsyncClient()

diff --git a/tests/common/test_client.py b/tests/common/test_client.py
@@ -174,8 +174,10 @@ def fake_send_packet(pkt):
     def test_disconnect_not_connected(self):
         c = client.Client()
         c.state = 'foo'
+        c.sid = 'bar'
         c.disconnect()
         self.assertEqual(c.state, 'disconnected')
+        self.assertIsNone(c.sid)
 
     def test_disconnect_polling(self):
         c = client.Client()