Do not reset connection when packet queue timeouts (#110)

miguelgrinberg · Jun 8, 2019 · e64e5a6 · e64e5a6
1 parent 5b87010
commit e64e5a6
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/engineio/asyncio_client.py b/engineio/asyncio_client.py
@@ -509,7 +509,6 @@ async def _write_loop(self):
             except (self.queue.Empty, asyncio.TimeoutError,
                     asyncio.CancelledError):
                 self.logger.error('packet queue is empty, aborting')
-                self._reset()
                 break
             if packets == [None]:
                 self.queue.task_done()

diff --git a/engineio/client.py b/engineio/client.py
@@ -591,7 +591,6 @@ def _write_loop(self):
                 packets = [self.queue.get(timeout=timeout)]
             except self.queue.Empty:
                 self.logger.error('packet queue is empty, aborting')
-                self._reset()
                 break
             if packets == [None]:
                 self.queue.task_done()

diff --git a/tests/asyncio/test_asyncio_client.py b/tests/asyncio/test_asyncio_client.py
@@ -1069,7 +1069,7 @@ def test_write_loop_polling_two_packets_done(self):
         c._send_request.mock.assert_called_once_with(
             'POST', 'http://foo', body=p.encode(),
             headers={'Content-Type': 'application/octet-stream'})
-        self.assertEqual(c.state, 'disconnected')
+        self.assertEqual(c.state, 'connected')
 
     def test_write_loop_polling_bad_connection(self):
         c = asyncio_client.AsyncClient()

diff --git a/tests/common/test_client.py b/tests/common/test_client.py
@@ -1011,7 +1011,7 @@ def test_write_loop_polling_two_packets_done(self):
         c._send_request.assert_called_once_with(
             'POST', 'http://foo', body=p.encode(),
             headers={'Content-Type': 'application/octet-stream'})
-        self.assertEqual(c.state, 'disconnected')
+        self.assertEqual(c.state, 'connected')
 
     def test_write_loop_polling_bad_connection(self):
         c = client.Client()