Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending binary data using client does not work #112

Closed
akgondber opened this issue May 27, 2019 · 4 comments
Closed

Sending binary data using client does not work #112

akgondber opened this issue May 27, 2019 · 4 comments
Assignees
Labels

Comments

@akgondber
Copy link

No description provided.

@miguelgrinberg
Copy link
Owner

Binary packets sent through WebSocket are sent as strings. I'm not sure if the problem is in the WS client itself or in how I'm using it. This issue does not exist when using the asyncio client, which uses a different websocket client.

@miguelgrinberg
Copy link
Owner

@akgondber can I ask you to test the master branch of this package? I believe I have addressed the problem with binary payloads. I missed the fact that the websocket client has a separate send function for binary.

@akgondber
Copy link
Author

I have tested changes in the master branch. Now it works correctly. Thank you for the library and this fix.

@miguelgrinberg
Copy link
Owner

Released as 3.7.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants