Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect traceback on application error #49

Closed
intra-au opened this issue May 31, 2017 · 1 comment
Closed

incorrect traceback on application error #49

intra-au opened this issue May 31, 2017 · 1 comment
Assignees
Labels

Comments

@intra-au
Copy link

socket.py keeps exception in reraise_exc variable and try to raise it with "raise reraise_exc", however that's causing wrong traceback on stderr.
Since the blank raise raises the last exception below is the fix (I've commented raise "reraise_exc" and just use "raise"
if reraise_exc:
raise

the problem it was causing is the last line of traceback was:


File "/usr/local/lib/python2.7/dist-packages/engineio/socket.py", line 230, in _websocket_handler
raise reraise_exc

using just raise it displays correct traceback for the previous exception

@miguelgrinberg miguelgrinberg self-assigned this May 31, 2017
miguelgrinberg added a commit that referenced this issue Jun 22, 2017
Fixes #49 (again and hopefully better)
@miguelgrinberg
Copy link
Owner

@intra-au can I ask you to install the master branch direct from git and confirm that the problem is resolved? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants