Ctskf 632 virus scan #6392
Draft
Ctskf 632 virus scan #6392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This page is (probably) temporary
jrmhaig
force-pushed
the
ctskf-632-virus_scan
branch
12 times, most recently
from
3922716
to
9131fd2
Compare
jrmhaig
force-pushed
the
ctskf-632-virus_scan
branch
from
9131fd2
to
755ebe4
Compare
|
mpw5
reviewed
Jan 8, 2024
Comment on lines
+2
to
+15
| # check: false, | ||
| # daemonize: true, | ||
| config_file: Rails.root.join('config', 'clamd.container.conf'), | ||
| # error_clamscan_missing: true, | ||
| # error_clamscan_client_error: false, | ||
| # error_file_missing: true, | ||
| # error_file_virus: false, | ||
| # fdpass: false, | ||
| stream: true, | ||
| # reload: false, | ||
| # output_level: 'medium', | ||
| # executable_path_clamscan: 'clamscan', | ||
| # executable_path_clamdscan: 'clamdscan', | ||
| # executable_path_freshclam: 'freshclam', |
There was a problem hiding this comment.
Would we want to enable any of these options when we implement this? I notice on Paul's PR that several of them are set to true. Not necessarily something for now, it can probably be decided on when we do the implementation.
There was a problem hiding this comment.
I copied this from the README of clamby and I believe that they are all the defaults except the two that I have changed. I left them in for reference in case we decide there are any we need to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ticket
board ticket description
Why
How
TODO (wip)