A 'name' must be trimmed #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Apr 28, 2023
…cli (0.0.3) CHANGES: - Fix the OCaml 5 support (@dinosaure, @Leonidas-from-XIV, mirage/conan#21) - Apply `ocamlformat.0.24.1` (@dinosaure, mirage/conan#22) - Fix lower bounds (@gridbugs, mirage/conan#23) - Add `-p` name to dune install invocation (@reynir, mirage/conan#24, mirage/conan#19) - Fix the MacOS support (@dinosaure, mirage/conan#25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error appears only on MacOS about our tests, probably because the executable produced in such context is a bit different and follow an other pass than an usual one (one Linux).
nameused for indirection don't contain whitespace but they can be followed by a comment. We must take only the name part and ignore the comment.