Feature/note support #276
Merged
Feature/note support #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaisabel
suggested changes
Mar 29, 2021
There was a problem hiding this comment.
This works great as written, but could use a few additional quality of life features and documentation additions:
- CHANGELOG needs to be updated to mention note support
- README needs to be updated to mention STIX 2.1 support
- Add mention of STIX 2.0 and 2.1 support to "loading content from local files"
- Add mention that STIX 2.1/TAXII 2.1 is not supported when loading from a TAXII server to "loading content from a TAXII server'
- We should probably denote the presence of a note somehow in the UI outside of the tooltip.
- Probably add a "comment" underline style to technique cells which have notes, unless you can come up with a better alternative which can differentiate comments and notes.
- This should be documented in the help document somewhere.
…k/attack-navigator into feature/note-support
isaisabel
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for note SDOs