Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#181 layer upgrade UI update #289

Merged

Conversation

iguannalin
Copy link
Contributor

Moved sidebar to inside matrix layout, rather than outside as overlay on top of app

@iguannalin iguannalin requested a review from clemiller May 5, 2021 23:31
Copy link
Contributor

@clemiller clemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great overall! It's definitely an improvement from having it overlay the entire application. Just one note: we may want to move the mat-drawer-container and mat-drawer-content tags from the app component to the data table component as well, and display the matrix views inside of the mat-drawer-content. Currently, the sidebar overlaps the right side of the data table, which blocks a number of techniques from the user's view, and doesn't extend down to the bottom of the page. This might require some additional modifications, such as setting the overflow of the mat-drawer-content when the sidebar is open so the user can scroll through the datatable, and preventing the sidebar from closing when the user clicks outside.

…ded autosize and mode="side" setting to mat-drawer to push matrix to the side when sidebar is open
@iguannalin iguannalin requested a review from clemiller May 6, 2021 19:42
Copy link
Contributor

@clemiller clemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@clemiller clemiller merged commit ba49817 into feature/#181-layer-upgrade-ui May 17, 2021
@iguannalin iguannalin deleted the feature/#181-layer-upgrade-ui-update branch May 17, 2021 14:46
@iguannalin iguannalin restored the feature/#181-layer-upgrade-ui-update branch May 17, 2021 15:34
@iguannalin iguannalin deleted the feature/#181-layer-upgrade-ui-update branch May 17, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants