-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#204 consolidate search and multiselect #301
Feature/#204 consolidate search and multiselect #301
Conversation
…reated object in which to store stix bundle changes
…entire Navigator site
…ded autosize and mode="side" setting to mat-drawer to push matrix to the side when sidebar is open
…order surround the sidebar as well
…nd updated function of search icon in toolbar
…le component search button, and in the layer upgrade component sidebar done button
…arch button" -- search icon in toolbar should function as before sidebar updates (this is to keep the changes separate, as they are different issues) This reverts commit 222d9dc.
…he sidebar, depending on where it was clicked from
…o render techniques in search feature
…d, and removed multiselect
…function, as it was throwing an error trying to convert undefined to lower case
…eature/#181-layer-upgrade-ui-update
…ui-update Feature/#181 layer upgrade UI update
…pdating with my changes to set the sidebar content
…ebar; Updated search feature to query StixObjects also--the search queries the same decreasing number of StixObjects until either: 1) there's no results, or 2) the query clears out (is an empty string ""); it was too slow to repeat the search with a new set of StixObjects each time, so there's getStixData() and getStixResults()
…f query is completely different from the last query
…s part of issue#181)
…feature from Data Service (this is part of issue#181)
…ion and removed ::ng-deep
@isaisabel, I looked into this and tested the performance of the mouseenter event in 4 environments:
I tested this by running the performance profiling, reloading the page, and hovering over the 4 techniques in the top left corner after the matrix loads. It seems to take consistently ~60-80ms for the mouseenter event when running locally (I ran these about 2-3 times), and significantly less at 20ms in the deployed version on the mitre-attack site. If I'm doing this right and understanding you correctly, I'm not sure if there's a significant lag in the mouseenter/hover because of the changes in this feature branch. One thing I do think concerns me about performance when working on this feature though, was the loading of all the techniques in the search component sidebar (since it now loads & searches techniques across domains and all techniques). Screenshots: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have found one major bug in my second review. When switching between layers of different domains, the contents of the sidebar does not update properly until a query is added.
Steps to reproduce:
- Open two layers, one Enterprise and one Mobile
- Open the sidebar on both tabs
- Switch back and forth between the two tabs. The counts and listed objects should change when switching tabs since the data under each domain is different, but this does not happen. Only when a query is inputted do the objects listed refresh.
Aside from that everything looks great, and the added denounce definitely makes the search input more performant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I pushed a commit which updates the help page documentation which was pretty old for this feature (it didn't mention mitigations which were not originally part of the interface and generally needed a touch-up).
See issue: #204