Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where the
select techniques across parents
/select sub-techniques with parent behavior
on hover were not correct.Only concern I have is that I've removed the line comparing the attackIDs of the current and highlighted techniques to see if it should be highlighted:
if (compare.attackID == compareTo.attackID) return true;
This was removed because instead of storing Technique in the highlightedTechniques, I'm now saving an array of the technique IDs, for faster lookup (and because the search component needs it as an array). I'm hoping that checking both the technique and tactic when the user hovers over a cell in the matrix should suffice.