Fix/#204 technique hover #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in the matrix with the tactic/parent selection behavior toggled
isaisabel
suggested changes
Jul 16, 2021
There was a problem hiding this comment.
This fix does seem to fix the highlight behavior with "select sub-techniques with parent." However, there is another bug observed in that feature which was not fixed (but was probably introduced at the same time).
The tooltip for the parent also shows when the child is hovered, which isn't intended behavior:
Compare this to the behavior on master, where the tooltip for the parent isn't shown:
…odel called highlightedTechnique--which is the singular technique to differentiate the technique currently being hovered over vs. all techniques that are highlighted (to fix tooltip bug that was showing two tooltips)
isaisabel
approved these changes
Jul 20, 2021
nav-app/src/app/matrix/technique-cell/technique-cell.component.ts
Outdated
Show resolved
Hide resolved
isaisabel
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where the
select techniques across parents/select sub-techniques with parent behavioron hover were not correct.Only concern I have is that I've removed the line comparing the attackIDs of the current and highlighted techniques to see if it should be highlighted:
if (compare.attackID == compareTo.attackID) return true;This was removed because instead of storing Technique in the highlightedTechniques, I'm now saving an array of the technique IDs, for faster lookup (and because the search component needs it as an array). I'm hoping that checking both the technique and tactic when the user hovers over a cell in the matrix should suffice.