Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable liveness and readiness probes #99

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

mattmattox
Copy link
Contributor

This PR introduces the ability to customize the liveness and readiness probes through the chart's values.yaml. Users can now adjust the initial delay, period, timeout, success threshold, and failure threshold for both probes. Additionally, it's now possible to disable either probe by setting the enabled flag to false.

This enhancement improves the flexibility of the deployment configurations, allowing users to tailor the health check mechanisms to better suit their specific service requirements and operational environments.

Changes made:

  • Updated values.yaml to include default configurations for liveness and readiness probes. (Doesn't change the default behavior)
  • Modified deployment.yaml to use the values from values.yaml for setting up the probes, including conditional checks to enable or disable them as configured.

This change resolves #96, addressing the need for more configurable liveness and readiness probes as requested by the community.

Copy link
Member

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for your contribution. 🙂👍 Give me a ping (either here, or on the Kubernetes Slack) whenever you want me to tag a new release.

@martin-helmich martin-helmich merged commit 9faff4a into mittwald:master Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modify liveness probes from values.yaml
2 participants