Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: upgrade to MSVC 2017 #47

Closed
Be-ing opened this issue May 27, 2018 · 7 comments
Closed

Windows: upgrade to MSVC 2017 #47

Be-ing opened this issue May 27, 2018 · 7 comments
Assignees

Comments

@Be-ing
Copy link
Contributor

Be-ing commented May 27, 2018

We are currently using MSVC 2015.

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 31, 2018

Shall we target this to 2.3? Any volunteers to take this up? @Pegasus-RPG?

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 31, 2018

Related: #59

@rryan
Copy link
Member

rryan commented Aug 31, 2018

Is anything blocked on this? We could, but I'd say it's pretty low priority given things are working fine with VS2015.

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 31, 2018

AFAIK nothing is currently blocked on this. But I'd like to be proactive and keep libraries and build tools up to date each release so we take care of them before they become problems.

@sblaisot
Copy link
Member

I don't think you can have both VS2015 and VS2017 installed on the same system without some bad interaction problems.
So upgrading MSVS means either you create a new build slave server and target specifically this server for the builds needing the new MSVS (new major version) and keep the older branches on the older build server, or you upgrade the existing build slave and start building all branches and versions on the new MSVS, wich doesn't seems a good switch between minor releases.

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 31, 2018

I agree, switching the build tools for a minor release would not be great. I guess we'll need a new VM with the new compiler when we switch then.

@rryan rryan self-assigned this Sep 27, 2018
@rryan
Copy link
Member

rryan commented Oct 9, 2018

mixxxdj/mixxx#1833 is the last step to fixing this.

@rryan rryan closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants