Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move state from Jenkins configuration scripts to this repository #59

Open
Be-ing opened this issue Aug 31, 2018 · 3 comments
Open

move state from Jenkins configuration scripts to this repository #59

Be-ing opened this issue Aug 31, 2018 · 3 comments

Comments

@Be-ing
Copy link
Contributor

Be-ing commented Aug 31, 2018

Currently, some of the Jenkins configuration scripts rely on specific version numbers of libraries. This is cumbersome to maintain because it requires changing versions numbers scattered in different places (build scripts, Jenkins config scripts for PRs, Jenkins config scripts for release branches, Jenkins build scripts for master branch) when a library is updated. Instead, everything that changes regularly with dependency versions should be in this repository.

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 31, 2018

The Jenkins configuration scripts for Windows assume that the ASIO SDK and MSVC Redistributable are present on the build runner and assume specific filenames. This setup requires write access to the build runner's storage to update those dependencies. Instead, those should be downloaded by the build scripts if they are not already cached in the Jenkins workspace like how the macOS scripts work.

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 31, 2018

After this issue is fixed, I think it would be a good idea to mirror the scripts in the Jenkins configuration in this repository in case something happens to the main Jenkins server.

@rryan
Copy link
Member

rryan commented Sep 27, 2018

In #67, the ASIO SDK is downloaded by the build process and the redistributable installers and DLLs are copied from the MSVS install root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants