Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traktor S4 Mk3] Screen support #12557

Closed

Conversation

acolombier
Copy link
Contributor

@acolombier acolombier commented Jan 12, 2024

This is related to PR #12259.

New mapping feature:

  • Record button can be use to toggle scrolling waveform
  • Mute button can be use to minify widget and get full screen artwork
  • New shortcut to set loop backward (the playposition is the endpoint instead of start point)
  • Ability to change hotcue color with shortcut

Depends of:

A branch with all dependencies can be used to test/use this feature while the above dependencies gets reviewed. Branch is acolombier:traktor-s4-mk3-updated

TODO:

  • Documentation update

@ywwg
Copy link
Member

ywwg commented Mar 26, 2024

can you pull in the latest main changes to resolve the conflict?

@acolombier acolombier force-pushed the feat/traktor-s4-mk3-screen-support branch from ca6e8cf to d834888 Compare March 26, 2024 15:27
@ywwg
Copy link
Member

ywwg commented Mar 26, 2024

I think my next request would be for overview explanatory comments on all the new objects / files -- mixxx project has a bad habit of not doing code documentation and I'd like to fix that.

@acolombier acolombier force-pushed the feat/traktor-s4-mk3-screen-support branch from d834888 to 1f3f0dc Compare March 26, 2024 15:29
@ywwg
Copy link
Member

ywwg commented Mar 26, 2024

(ah, I'm getting confused between branches, no c++ in this PR)

@acolombier acolombier force-pushed the feat/traktor-s4-mk3-screen-support branch from 1f3f0dc to 2d831dd Compare March 26, 2024 17:09
@acolombier
Copy link
Contributor Author

@ywwg Yes, this PR is only the mapping part (QML + JS), though I can take your comment for #11407

That being said, I agree with you - enforcing code documentation would be a great thing, even for QML. I'm just not so sure how it would look like tho. But I'm keep to do some work on this, so the first QML mapping kinda set standards for future contribution

@acolombier acolombier force-pushed the feat/traktor-s4-mk3-screen-support branch from 2d831dd to a7f1b44 Compare March 27, 2024 18:58
@github-actions github-actions bot added the qml label Mar 27, 2024
@acolombier acolombier force-pushed the feat/traktor-s4-mk3-screen-support branch 2 times, most recently from ea51a36 to d11c916 Compare March 28, 2024 11:56
@acolombier acolombier force-pushed the feat/traktor-s4-mk3-screen-support branch from d11c916 to 8dcc83e Compare May 24, 2024 12:11
@acolombier acolombier force-pushed the feat/traktor-s4-mk3-screen-support branch from 8dcc83e to 0eac4e3 Compare May 24, 2024 12:11
@acolombier
Copy link
Contributor Author

Cannot be completed due to rejection of #12199

Will be kept updated in acolombier:traktor-s4-mk3-updated for anyone interested

@acolombier acolombier closed this May 24, 2024
@ywwg
Copy link
Member

ywwg commented Jun 3, 2024

Per discussion, this work is not abandoned but on the back burner while we do a proper design for controller data sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants