Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FILE line to Cuefile to include file path for each track #13365

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

presentformyfriends
Copy link

Fixes #13321

This PR adds a FILE line to the Cuefile to show a filepath for each track (see issue for more information).

Copy link
Contributor

@acolombier acolombier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, as @fwcd suggested, it would be great to make that an option. To do so, you could add a boolean to EngineRecord (like m_bCueUsesFileAnnotation), and initialise it in the EngineRecord::updateFromPreferences, using m_pConfig->getValue().
You can use Qt Designer to edit src/preferences/dialog/dlgprefrecorddlg.ui and add the logic in src/preferences/dialog/dlgprefrecord.cpp to ahndle the preference edition. Happy to do that part if you would like me to.

@ronso0
Copy link
Member

ronso0 commented Jun 13, 2024

Just a word on Qt Designer: that potentially rearranges the .ui files (for no reason) which produces a unreviewable diff.
If that happens please resort to editing the ui file manually in a text editor.

@presentformyfriends
Copy link
Author

@ronso0 Thanks for the tip, I will pay attention to the .ui files order and will edit manually if need be

@presentformyfriends
Copy link
Author

@acolombier Quick question, I just read in the Developer Guidelines to prefer merging over rebasing as rebasing apparently causes problems. I did not know this, and can't remember if I rebased or not. Is there a way for me to check if I rebased? Sorry if this is a dumb question. Thanks!

@JoergAtGithub
Copy link
Member

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@ronso0
Copy link
Member

ronso0 commented Jun 13, 2024

@presentformyfriends Merging is preferred becasue rebasing rewrites the commit history and may detach review comments (which could mean a lot / everything hd to be reviewwd again)

Though, for this minimal PR that's irrelevant IMO.

@presentformyfriends
Copy link
Author

Thanks @JoergAtGithub just signed it!

Welcome at Mixxx! As a first-time contributor we need you to sign the

@presentformyfriends
Copy link
Author

Got it, good to know!

Merging is preferred becasue rebasing rewrites the commit history and may detach review comments (which could mean a lot / everything hd to be reviewwd again)

Though, for this minimal PR that's irrelevant IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add a FILE line to the Cue Sheet
4 participants