-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FILE line to Cuefile to include file path for each track #13365
base: main
Are you sure you want to change the base?
Add FILE line to Cuefile to include file path for each track #13365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, as @fwcd suggested, it would be great to make that an option. To do so, you could add a boolean to EngineRecord
(like m_bCueUsesFileAnnotation
), and initialise it in the EngineRecord::updateFromPreferences
, using m_pConfig->getValue()
.
You can use Qt Designer to edit src/preferences/dialog/dlgprefrecorddlg.ui
and add the logic in src/preferences/dialog/dlgprefrecord.cpp
to ahndle the preference edition. Happy to do that part if you would like me to.
Just a word on Qt Designer: that potentially rearranges the .ui files (for no reason) which produces a unreviewable diff. |
@ronso0 Thanks for the tip, I will pay attention to the .ui files order and will edit manually if need be |
@acolombier Quick question, I just read in the Developer Guidelines to prefer merging over rebasing as rebasing apparently causes problems. I did not know this, and can't remember if I rebased or not. Is there a way for me to check if I rebased? Sorry if this is a dumb question. Thanks! |
Welcome at Mixxx! |
@presentformyfriends Merging is preferred becasue rebasing rewrites the commit history and may detach review comments (which could mean a lot / everything hd to be reviewwd again) Though, for this minimal PR that's irrelevant IMO. |
Thanks @JoergAtGithub just signed it!
|
Got it, good to know!
|
Fixes #13321
This PR adds a FILE line to the Cuefile to show a filepath for each track (see issue for more information).