Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library scan: log summary and show popup #13427

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 1, 2024

This emphasizes the logged scan summary and allows to show a respective popup, both for automatic scan at startup and manual scan.

For me, this is a step towards being able to manually find successors for moved missing tracks, may also be helpful for the New Tracks filter/feature.

info [LibraryScanner 1] ----------------------------------------------
info [LibraryScanner 1] Library scan finished after 963 ms
info [LibraryScanner 1]  1235 unchanged directories
info [LibraryScanner 1]  197 changed/added directories
info [LibraryScanner 1]  0 tracks verified from changed/added directories
info [LibraryScanner 1]  0 new tracks
info [LibraryScanner 1]  0 moved tracks
info [LibraryScanner 1]  0 missing tracks
info [LibraryScanner 1] ----------------------------------------------

image
if nothing changed it displays only duration and ""No changes were detected."

TODO
Find an alternative for int LibraryScanner::cleanUpScan() to get the number of relocated tracks. ✔️

@ronso0 ronso0 changed the title Lib scan summary etc Library scan: log summary and show popup Jul 3, 2024
@ronso0
Copy link
Member Author

ronso0 commented Jul 3, 2024

Find an alternative for int LibraryScanner::cleanUpScan() to get the number of relocated tracks.

Simply storing that in an LibraryScanner int member seems fine to me (reset when scan is started, no need to bother scannerGlobal with this).
Wdyt?

@JoergAtGithub
Copy link
Member

show a respective popup, both for automatic scan at startup and manual scan

It's a nice addition to get a feedback, when I triggered the scan amnually. But I would no like to get this pop-up, when I start Mixxx.

@ronso0
Copy link
Member Author

ronso0 commented Jul 4, 2024

Funny thing is, I moved the connection to CoreServices so we can always get the popup.

Why do you consider the info popup disturbing / not helpful for the autorun scan during startup?

@ronso0 ronso0 marked this pull request as ready for review July 4, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants