Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to control active step when activeStepIndex change #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

groomain
Copy link

This PR allow you to control the active step outside the wizard.

This PR allow you to control the active step outside the wizard.
@groomain groomain requested a review from mjangir as a code owner April 15, 2022 15:41
@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2022

⚠️ No Changeset found

Latest commit: 2a1b7a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@groomain
Copy link
Author

Hello @mjangir any plan to merge these pull requests ?

@mjangir
Copy link
Owner

mjangir commented Apr 22, 2022

Hello @mjangir any plan to merge these pull requests ?

Pipeline failed.

@groomain
Copy link
Author

Sorry, I forgot to commit the import. Normally it should not failed now.

@mjangir
Copy link
Owner

mjangir commented Apr 26, 2022

@groomain Check line 18 if it is correct!

src/useWizard.ts Outdated
useEffect(
() => {
setCurrentStep(activeStepIndex);
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a comma here. Did you find it working in your local machine? I'm sure it didn't.

@groomain
Copy link
Author

groomain commented May 4, 2022

is it good for you?

@groomain
Copy link
Author

The docs failed to be deployed. Is it because of the PR or juste a problem on github ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants