-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Reland "[LCP] Add animated image support""
This reverts commit 2ebdf0d26ea55271942e6b5ed585a08016a3e80b. Reason for revert: Still appears to be causing flakiness on PageLoadMetricsBrowserTestWithAnimatedLCPFlag.PageLCPNonAnimatedImage Flakiness stopped while this was reverted and resumed when it relanded. https://screenshot.googleplex.com/85Ucaejfj42M5ov.png https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PageLoadMetricsBrowserTestWithAnimatedLCPFlag.PageLCPNonAnimatedImage&testType=browser_tests%20on%20Mac-11 https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/1167/overview Original change's description: > Reland "[LCP] Add animated image support" > > This is a reland of b7d510c06e0436cfb4bd7260175cd460b949225c > > Original change's description: > > [LCP] Add animated image support > > > > This CL adds support for better handling of animated images in LCP: > > * A new attribute is exposing the first animated frame's paint time > > (behind a flag). > > * `startTime` is not changed. > > * The PageLoadMetrics reported for LCP are set to that first frame paint > > time for animated images (behind another flag). > > * Entries are not emitted until the image is loaded. > > > > Relevant spec issue: > > w3c/largest-contentful-paint#83 > > > > Change-Id: I6bb01eacb4f200f9c032ffcfcd9a1a41126a7773 > > Bug: 1260953 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226157 > > Commit-Queue: Yoav Weiss <[email protected]> > > Reviewed-by: Nicolás Peña Moreno <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#935133} > > Bug: 1260953 > Change-Id: I5eaaf0cfd1daa7fb905e68aed4994cb931dc7750 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247449 > Commit-Queue: Yoav Weiss <[email protected]> > Reviewed-by: Nicolás Peña Moreno <[email protected]> > Cr-Commit-Position: refs/heads/main@{#935635} Bug: 1260953 Change-Id: I07f60d8c423a3458cf7230843a8258682be134ad No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3249376 Commit-Queue: Glen Robertson <[email protected]> Auto-Submit: Glen Robertson <[email protected]> Owners-Override: Glen Robertson <[email protected]> Reviewed-by: Alan Cutter <[email protected]> Cr-Commit-Position: refs/heads/main@{#935767} NOKEYCHECK=True GitOrigin-RevId: 2fb2daf6c7fddaa3f6c8b8e0ac5787ef1e0f44a1
- Loading branch information
Glen Robertson
authored and
Copybara-Service
committed
Oct 28, 2021
1 parent
fd282b8
commit 03f715d
Showing
26 changed files
with
57 additions
and
359 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.