Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: run npm install from dune #181

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jchavarri
Copy link
Collaborator

While publishing in opam repository, I realized calling dune runtest would fail because we weren't tracking the dependency in node_modules anywhere (it was assumed that npm install would be called manually).

This PR adds this dependency inside dune itself by leveraging the recently added directory targets. ref: ocaml/dune#6168.

The yarn.lock was removed as it would lead to permission issues:

npm ERR! Error: EACCES: permission denied, open '/.../jsoo-react/_build/default/test/yarn.lock'

As there are barely any deps and we are already constraining to minor versions of them, we should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant