Sean/monomorph #27
Open
Sean/monomorph #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HaP, added basic nix shell with build deps & locale config, placeholder UPLC codegen module & functions. You almost certainly need the hie.yaml and .envrc to work on this so I committed those intentionally.
…n the annotation) + reworked pretty printer to... print prettily
… this as a temporary work branch)
…e expressions, necessary for fully typing the desugared typeclass declarations
…gly CoreFn desugaring code
…s-wip Sean/typed core fn.typeclasses wip
…Unknowns, small tweak to pretty printer
Sean/typed core fn.wip
…instantiatePolyTypes
…g dictionary types, (sort of) fixed let-generalization, ported over more tests
…inery. (We're now properly *reconstructing* the types)
Too many of them to fix now
…ps if we inline, working on recursive)
…le (bugs almost certainly remain)
…worked the IndexedPlated instance to be indexed on a name-context
…r and object desugarer, started working on final translation to PIR
…orking. TONS Of bugs. TONS of errors and undefineds and missing branches and etc.
klntsky
commented
Apr 17, 2024
| -- This gives us a way to report the exact location of the error (which may no longer correspond *at all* to | ||
| -- the location given in the SourcePos annotations due to inlining and monomorphization) | ||
| data TypeConvertError | ||
| = TypeConvertError (SourceType -> SourceType ) SourceType String |
There was a problem hiding this comment.
Please defunctionalize this
klntsky
commented
Apr 17, 2024
| -- idk if we need to specialize the whole group? | ||
| Just _ -> Just (Rec xs) | ||
|
|
||
| monomorphizeA :: Context -> Expr Ann -> Monomorphizer (Expr Ann) |
There was a problem hiding this comment.
Please use a more descriptive name
klntsky
commented
Apr 17, 2024
| <> "\n is not an abstraction or variable" | ||
|
|
||
| -- I *think* all CTors should be translated to functions at this point? | ||
| -- TODO: We can make sure the variables are well-scoped too |
klntsky
commented
Apr 17, 2024
| dict <- collectRecBinds initialRecDict ty d targExpr | ||
| let renameMap = (\(i,t,_) -> (i,t)) <$> dict | ||
| bindingMap = M.elems dict | ||
| cxt = foldl' (\acc (idx,tyx)-> M.insert idx tyx acc) d $ (\(a,b,_) -> (a,b)) <$> M.elems dict |
There was a problem hiding this comment.
Use flip and uncurry for the folding function
klntsky
commented
Apr 17, 2024
| assembleDesugaredObjectLit expr _ [] = pure expr -- TODO better error | ||
| assembleDesugaredObjectLit _ _ _ = error "something went wrong in assembleDesugaredObjectLit" | ||
|
|
||
| desugarObjectAccessor :: SourceType -> PSString -> Expr Ann -> Maybe (Expr Ann) |
There was a problem hiding this comment.
Could you please add a small illustration in a comment above every function like this? Perhaps containing some semi-real PS code snippet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR.
Checklist: