Sean/mandatory kinds #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HaP, added basic nix shell with build deps & locale config, placeholder UPLC codegen module & functions. You almost certainly need the hie.yaml and .envrc to work on this so I committed those intentionally.
…n the annotation) + reworked pretty printer to... print prettily
… this as a temporary work branch)
…e expressions, necessary for fully typing the desugared typeclass declarations
…gly CoreFn desugaring code
…s-wip Sean/typed core fn.typeclasses wip
…Unknowns, small tweak to pretty printer
Sean/typed core fn.wip
…instantiatePolyTypes
…g dictionary types, (sort of) fixed let-generalization, ported over more tests
…inery. (We're now properly *reconstructing* the types)
…eed to distinguish between free and bound tyvars and only require annotations only in tyvar binders & free tyvars
… & small mistakes in the CST conversion rewrite
klntsky
reviewed
Jun 4, 2024
| C.Function -> Left $ "function types should be caught in apps" | ||
| C.Array -> pure $ TyBuiltin () (PLC.SomeTypeIn PLC.DefaultUniProtoList) -- is this wrong? do we want a SOP list? too tired to know | ||
| C.String -> pure $ TyBuiltin () (PLC.SomeTypeIn PLC.DefaultUniString) | ||
| C.Char -> pure $ TyBuiltin () (PLC.SomeTypeIn PLC.DefaultUniInteger) |
There was a problem hiding this comment.
Does UPLC have primitives for working with Char? unicode codepoint <-> symbol stuff? It might be a good idea to remove Char completely
klntsky
requested changes
Jun 4, 2024
| C.String -> pure $ TyBuiltin () (PLC.SomeTypeIn PLC.DefaultUniString) | ||
| C.Char -> pure $ TyBuiltin () (PLC.SomeTypeIn PLC.DefaultUniInteger) | ||
| C.Int -> pure $ TyBuiltin () (PLC.SomeTypeIn PLC.DefaultUniInteger) | ||
| C.Boolean -> pure $ TyBuiltin () (PLC.SomeTypeIn PLC.DefaultUniBool) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to the ASTs (everything after the CST) and CST->AST conversion functions which ensure that all type variables are explicitly kinded. That is: Type variables used to be
And now they are:
This also includes Vladimir's changes to the parser that make kind annotations mandatory at binding sites and change the syntax for Rows, such that Rows are now written with brackets:
(This was needed to disambiguate singleton rows from type variables with kind annotations. E.g.
(a :: Int)was ambiguous before the change.)Checklist: