Add authentication #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @funblaster22 thank you so much for the PR. It's great to have you here because I love to see people making use of this information. I agree that adding the "scoutbook" tag is a great idea because it will help people find this repo. I've added the tag. This is a good addition but did you happen to write a test case as described here https://github.com/mmarseglia/scouting-api?tab=readme-ov-file#update-the-openapi-specification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented how to get a session JWT using username and password. Also, have you considered adding
scoutbookto the repo tags? I think it would make it easier to find, as I found this repo linked through a Reddit post.