Fix for division by zero issue #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the parameter words_per_minute at _config.yml is not defined and the template says that must show read_time then will be divide a number by zero, a fix is verify that parameter and show a message when this is empty or zero. already localized for spanish
cjmadsen
pushed a commit
to cjmadsen/cjmadsen.github.io
that referenced
this pull request
Dec 7, 2016
Update demo link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#317 could pass when the parameter words_per_minute is not defined in _config.yml and the parameter read_time at post are defined in true.
The PR show a message when detects undefined the parameter words_per_minute in read_time.html
the other parameter is handled by other parameter outside this file.