Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hand cursor from author location #354

Closed
wants to merge 2 commits into from
Closed

Remove hand cursor from author location #354

wants to merge 2 commits into from

Conversation

amweiss
Copy link

@amweiss amweiss commented Jun 11, 2016

No description provided.

@mmistakes
Copy link
Owner

Can you run npm run build:css and commit the compiled main.css as well so I can merge it all in together?

@amweiss
Copy link
Author

amweiss commented Jun 12, 2016

Added.

@@ -23,7 +23,7 @@ <h3 class="author__name">{{ author.name }}</h3>
<button class="btn btn--inverse">Follow</button>
<ul class="author__urls social-icons">
{% if author.location %}
<li><i class="fa fa-fw fa-map-marker" aria-hidden="true"></i> {{ author.location }}</li>
<li class="author__location"><i class="fa fa-fw fa-map-marker" aria-hidden="true"></i> {{ author.location }}</li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a closer look and adding the author__location class to the <li> element is unnecessary. As is the .author__location declaration in _sidebar.scss.

If cursor: default is added to .author__urls here you can get away with adding a single line and not having to mess with the sidebar's markup.

@mmistakes mmistakes closed this in 166b8f7 Jun 13, 2016
mmistakes added a commit that referenced this pull request Jun 13, 2016
@amweiss amweiss deleted the location branch June 21, 2016 21:06
sobkowiak pushed a commit to sobkowiak/sobkowiak.github.io-new that referenced this pull request Jul 18, 2016
sobkowiak pushed a commit to sobkowiak/sobkowiak.github.io-new that referenced this pull request Jul 18, 2016
jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this pull request May 6, 2017
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants