Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working on Windows #1

Closed
JesOb opened this issue Sep 17, 2020 · 6 comments
Closed

Not working on Windows #1

JesOb opened this issue Sep 17, 2020 · 6 comments
Assignees
@mob-sakai
Labels
bug Something isn't working released

Comments

@JesOb
Copy link

JesOb commented Sep 17, 2020

Plugin do something and adds Compilation directives CSHARP_8_OR_LATER...
but actually can not compile any C# 8 code
even csc.rsp -langversion:8.0 stop compiler function with error of uncompatible lang version

Screenshots
изображение

Environment (please complete the following information):

  • Unity Version 1.0.0
  • Platform: Editor(Windows)
  • Unity version: 2019.4.9f1
  • Build options: IL2CPP, .Net 4.x, URP
@JesOb JesOb added the bug Something isn't working label Sep 17, 2020
@JesOb
Copy link
Author

JesOb commented Sep 17, 2020 •
edited

Test with new empty project shows the same
изображение

csc.rsp
-langversion:8.0

@mob-sakai
Copy link
Owner

@Jes28
I want to ask you a few questions.

  • Do you see a log for CscSettings?
    image
  • Does Library/Microsoft.Net.Compilers.3.5.0/tools/csc.exe exist?
  • Could you please attach a minimal project (included Assets, Packages and ProjectSettings directories) that reproduces the issue?

@mob-sakai
Copy link
Owner

OK, the issue reproduced on my environment (Windows).
On macOS, it works.

@mob-sakai mob-sakai changed the title Actually dont work for me Not working on Windows Sep 17, 2020
mob-sakai added a commit that referenced this issue Sep 17, 2020
@mob-sakai
fix: Not working on Windows
b0d4eba 
close #1
github-actions bot pushed a commit that referenced this issue Sep 17, 2020
@semantic-release-bot
1.0.1
b494c20 
## [1.0.1](v1.0.0...v1.0.1) (2020-09-17)

### Bug Fixes

* Not working on Windows ([b0d4eba](b0d4eba)), closes [#1](#1)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mob-sakai
Copy link
Owner

@Jes28
Please try to use v1.0.1

@JesOb
Copy link
Author

JesOb commented Sep 17, 2020

Work like a charm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mob-sakai mob-sakai

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JesOb @mob-sakai