This repository has been archived by the owner on Aug 19, 2023. It is now read-only.
Chores: Fixed SSL and AllowAllHostNameVerifier Error. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the network client, in order to work on the target SDK for my project, it has backward compatibility. If you do not mind, can I use yours to write an open source library jopencage for kotlin devs.
|
FYI there is an opensource kotlin SDK https://github.com/sgimp/ktopencage |
|
@damade Thx for the PR.
Sure, feel free to do it, if the existing kotlin client does not fit your needs. I have currently very little available time for OSS, therefore it will take time to review, test and merge the PR. So if you can add additional unit tests for this, it would be much appreciated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the network client, in order to work on the target SDK for my project, it has backward compatibility.
If you do not mind, can I use yours to write an open source library jopencage for kotlin devs.