Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Support annotation-plug-in #64

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

micw
Copy link
Contributor

@micw micw commented Jan 9, 2018

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the new behavior (if this is a feature change)?

Support annotation-plug-in. Closes #63

  • Other information:

@micw
Copy link
Contributor Author

micw commented Jan 9, 2018

Please have a special look into 703248f:

The current behaviour was to update the state and call the "updateData" function. This triggered both, the state change client code as well as the "update data" function. Since the state change is always triggered, it's not possible to update data without updating the state.
In the commit I enabled initial support for updating the options (did it for legend, others are similar but need some testing). So I renamed refreshData() to update() and deprecated refreshData() because the supported options will always be updated together with the data.
There's no need to call the updateData function anymore.

Edit: an alternative approach would be to separate data and options and update both by independent function calls. The drawback is that the chart has only one update() function, so it would needed to be called twice.

@moberwasserlechner
Copy link
Owner

I try to have this reviewed and tested by the end of this week. BR

@moberwasserlechner
Copy link
Owner

moberwasserlechner commented Jan 23, 2018

Could you please add a demo view for this feature as well?

@moberwasserlechner moberwasserlechner added this to the 1.2.0 milestone Jan 27, 2018
@moberwasserlechner moberwasserlechner merged commit 16e49f0 into moberwasserlechner:master Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for annotation plug-in
2 participants