Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Added legend hide/show click listener. #73

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

RazvanML
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature: ability to listen on legend show/hide.

  • What is the current behavior? (You can also link to an open issue here)

The server was not notified about user click events

  • What is the new behavior (if this is a feature change)?

The server can listen on a hide/show data-set event.

  • Other information:

@moberwasserlechner
Copy link
Owner

Could you please create a view in the demo demonstrating your PR. thx

@RazvanML
Copy link
Contributor Author

Demo is added for the first chart, but it shall work with all the charts.

@RazvanML
Copy link
Contributor Author

Michael, is there anything I shall add to get the pull approved?

@moberwasserlechner
Copy link
Owner

No thanks for your work. I will approve it asap but it will take another few days because I have to finish a important project till next week ;)

@moberwasserlechner moberwasserlechner merged commit ab27315 into moberwasserlechner:master Mar 9, 2018
@moberwasserlechner moberwasserlechner added the release note added Release process label: I mark tasks with this if I have done the release note. label Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
demo requested release note added Release process label: I mark tasks with this if I have done the release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants