Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: android pressKey - power button #1169

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

depapp
Copy link
Contributor

@depapp depapp commented Jun 19, 2023

Proposed Changes

add new pressKey: power command.

Testing

appId: com.google.android.youtube
---
- launchApp
- tapOn: Subscriptions
- pressKey: power #lock screen
- pressKey: power #unlock screen
power.button.mov

Issues Fixed

fix #1167

@felipevolpone
Copy link
Contributor

Hey @depapp thank you very much for this PR 🙌 The Android part looks good, but we need to also support iOS. Would you be able to expand the PR to make that?

@depapp
Copy link
Contributor Author

depapp commented Aug 17, 2023

hi @felipevolpone thanks for the feedback.
since I couldn't find any APIs for the physical power button on iOS, I think it's not supported. any advise @felipevolpone ?

@chriswiesner
Copy link

i would need support for the menu button (keycode: 82) - probably also only available on Android.
Would be great if we could have support for keys which are android only 🙏

@felipevolpone
Copy link
Contributor

@depapp Sorry for such a long delay in answering you back. Given that iOS doesn't support that, we can move forward with this PR. Could you please update with the latest main branch so we can run the tests again? As soon it's green I'll merge it.

@depapp
Copy link
Contributor Author

depapp commented Oct 6, 2023

@depapp Sorry for such a long delay in answering you back. Given that iOS doesn't support that, we can move forward with this PR. Could you please update with the latest main branch so we can run the tests again? As soon it's green I'll merge it.

done @felipevolpone
could you please help to recheck 🙇🏻

@felipevolpone
Copy link
Contributor

Awesome work @depapp! Thanks for your contribution.

We are planning a Maestro release later this or early next week, either way in the next one this PR will be there

@felipevolpone felipevolpone merged commit 2aca402 into mobile-dev-inc:main Oct 9, 2023
1 check passed
@depapp depapp deleted the feat/physical-on-off branch October 10, 2023 00:56
@depapp
Copy link
Contributor Author

depapp commented Oct 10, 2023

Awesome work @depapp! Thanks for your contribution.

We are planning a Maestro release later this or early next week, either way in the next one this PR will be there

thanks @felipevolpone 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Physical on/off button
4 participants