Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hideKeyboard event #165

Merged
merged 8 commits into from
Sep 12, 2022
Merged

feat: add hideKeyboard event #165

merged 8 commits into from
Sep 12, 2022

Conversation

depapp
Copy link
Contributor

@depapp depapp commented Sep 12, 2022

hi @dmitry-zaitsev

description

I have an issue when try to tapOn a button that blocked by device keyboard.

  • the UI before keyboard is showing
    image

  • the UI after keyboard is showing
    image

solution

I've tried to add hideKeyboard() event to avoid that failed case (before tapOn() desired button)

Copy link
Contributor

@dmitry-zaitsev dmitry-zaitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please also add:

  • iOS support as mentioned in a comment
  • Integration test

@depapp
Copy link
Contributor Author

depapp commented Sep 12, 2022

Looks good, but please also add:

  • iOS support as mentioned in a comment
  • Integration test

hi @dmitry-zaitsev

I've updated the PR. could you please help to review it again? 🙇🏻

Copy link
Contributor

@dmitry-zaitsev dmitry-zaitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you

@dmitry-zaitsev dmitry-zaitsev merged commit 48231d8 into mobile-dev-inc:main Sep 12, 2022
@depapp depapp deleted the feature/hideKeyboard branch September 12, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants