Add 'maestro.platform' for javascript to determine platform #1747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add a
platform
property to themaestro
object in JavaScript, so as to determine iOS or Android at runtime.Why though?
Previously, an app that requested a few permissions would have lots of this:
I wanted to set the strings in JavaScript, but this would require prepending the flow with something like:
After this change:
Testing
I've tested this with a more trivial example:
flow.yml:
setSearchTerm.js:
Tested on iOS and Android, in Rhino & Graal.