-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow env values in setLocation
and travel
commands
#1769
Conversation
@prasanta-biswas thank you! I was about to open a PR solving this exact same issue |
@@ -33,7 +33,7 @@ internal class MaestroCommandTest { | |||
@Test | |||
fun `description (with a label)`() { | |||
// given | |||
val maestroCommand = MaestroCommand(SetLocationCommand(12.5266, 78.2150, "Set Location to Test Laboratory")) | |||
val maestroCommand = MaestroCommand(SetLocationCommand("12.5266", "78.2150", "Set Location to Test Laboratory")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write a test using negative coordinates ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alaksion done. Please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Hello @prasanta-biswas
|
This comment was marked as off-topic.
This comment was marked as off-topic.
@lucaswiechmann possible to merge this? |
setLocation
and travel
commands
maestro-orchestra/src/test/java/maestro/orchestra/MaestroCommandTest.kt
Outdated
Show resolved
Hide resolved
maestro-orchestra/src/test/java/maestro/orchestra/MaestroCommandTest.kt
Outdated
Show resolved
Hide resolved
Hey @prasanta-biswas |
@lucaswiechmann any updates on this? |
Hey @Alaksion, sorry about the delay! I plan to get to it this week. Thanks for understanding. |
@bartekpacia any update here? |
Hey @prasanta-biswas, could you rebase/merge with master? |
@bartekpacia done |
@bartekpacia test cloud job failed due to incorrect command. could you please check the job configuration? |
Don't worry about it, it's because the secret is missing |
@bartekpacia can you please retry the job if the missing secret is added? |
Hey @prasanta-biswas, don't worry about the secret, it's not available to jobs running for PRs open-source contributors. We want to guard that secret:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added test doesn't actually test the newly added feature. We need a test like this:
appId: com.example.app
---
setLocation:
latitude: ${LATITUDE}
longitude: ${LONGITUDE`
and then somehow mock those env vars
Proposed Changes
Fixes an issue where setLocation command fails if latitude and longitude values are passed from environment variables.
Testing
./gradlew :maestro-test:test
, all tests passed.env
keyword. It worked for both inline-defined latitude and longitude and passed from env.Issues Fixed
fixes #1765