Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration file parameter to test, cloud and record commands #1829

Merged
merged 17 commits into from
Sep 3, 2024

Conversation

Hyla96
Copy link
Contributor

@Hyla96 Hyla96 commented Jul 25, 2024

Proposed changes

The idea behind this PR is to allow multiple configurations for the same test suite. This comes really handy when having the same app with multiple flavors/schemas: you can run the same test on apps having the same codebase but different flows.

This changes add a new parameter --config to the following commands:
$ maestro cloud
$ maestro test
$ maestro record

The parameter is a path for the configuration file used for the flows.

Examples of use:
$ maestro test --config config/another_config.yml

Testing

  • Create a config file with a different name or a directory which is not the root.
  • Execute:
  • $ maestro test --config your_path_to_the_config/file.yml

@Hyla96 Hyla96 marked this pull request as draft July 25, 2024 13:40
@rasyid7
Copy link
Contributor

rasyid7 commented Jul 26, 2024

this is a better approach!
my workaround for this is by using yq

yq e '.includeTags=["Android"]' -i config.yaml
yq e '.excludeTags=["Broken","Flaky"]' -i config.yaml

@Hyla96 Hyla96 marked this pull request as ready for review July 26, 2024 07:55
Copy link
Member

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks a lot! I can see this being quite useful, and it doesn't increase code complexity a lot.

requesting further review from @amanjeetsingh150

@bartekpacia
Copy link
Member

The failing test is a false positive caused by #2005

Details Screenshot 2024-09-03 at 13 08 50

@Hyla96
Copy link
Contributor Author

Hyla96 commented Sep 3, 2024

@bartekpacia Thanks for addressing the review comments in the pr, I didn't have much time to go through them

@bartekpacia bartekpacia merged commit 2b73223 into mobile-dev-inc:main Sep 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants