Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing favicon #502

Merged
merged 2 commits into from
Dec 14, 2022
Merged

fix: missing favicon #502

merged 2 commits into from
Dec 14, 2022

Conversation

depapp
Copy link
Contributor

@depapp depapp commented Dec 14, 2022

Proposed Changes

fix: missing maestro studio favicon

Testing

./maestro studio

Issues Fixed

  • after
    Screen Shot 2022-12-14 at 10 48 23

  • before
    Screen Shot 2022-12-13 at 17 20 46

@Leland-Takamine
Copy link
Contributor

Thanks for the contribution @depapp! This is the icon we use on our website - can you update to use this styling?

image

@depapp
Copy link
Contributor Author

depapp commented Dec 14, 2022

e7fc9cc updated @Leland-Takamine 🙇🏻

image

@Leland-Takamine
Copy link
Contributor

Thanks for making that update! ✅

I'll merge once test pass

@Leland-Takamine Leland-Takamine merged commit 1d4f849 into mobile-dev-inc:main Dec 14, 2022
@depapp depapp deleted the fix-favicon branch December 14, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leland-Takamine Leland-Takamine Leland-Takamine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@depapp @Leland-Takamine