indicator-underglow: allow omissions; allow right-hand battery indicators. #29
+57
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors. This commit does two things: 1. Provides default values for all indicator-underglow properties, which allows you to omit them entirely if you do not want that indicator. 2. Allows the right side to specify battery indicators. I changed the phrasing of the battery left/right properties to be self/other instead. For (2), note that this currently does not work with the default Glove80 definition for the magic (indicator) key, since the right side does not received the macro-wrapped `&rgb_ug RGB_STATUS` keypress. See the usptream issue zmkfirmware#1494 for more. (I resolved this for my own build by incorporating the changes from zmkfirmware#1630.)
seansfkelley
commented
Mar 11, 2024
| 9 14 20 26 32 38 | ||
| 15 21 27 33 39 | ||
| 2 1 0 | ||
| 5 4 3 |
There was a problem hiding this comment.
I'm pretty sure this is right, but I didn't exhaustively check it.
|
|
||
| underglow_indicators: underglow-indicators { | ||
| compatible = "zmk,underglow-indicators"; | ||
| // Default: no indicators. Only `bat-self` is supported at the moment. |
There was a problem hiding this comment.
Thought I'd stub this out for discoverability. Per the PR description, this is actually kind of a trap, because it doesn't work with the default definition of the magic key without pulling in an upstream bugfix.
| capslock: | ||
| type: int | ||
| required: true | ||
| default: -1 |
There was a problem hiding this comment.
Not sure what the right way to define "nothing" was here, since I don't think these are nullable. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm not sure what your policy is around accepting PRs, but I put together this change for myself and thought I would at least publicize it a bit in case someone wanted similar behavior. With it, I am able to drop the layer indicator underglow (which I don't want) and put the right-hand battery indicator underglow on the right-hand side itself.
This commit does two things:
I changed the phrasing of the battery left/right properties to be self/other instead.
For (2), note that this currently does not work with the default Glove80 definition for the magic (indicator) key, since the right side does not received the macro-wrapped
&rgb_ug RGB_STATUSkeypress. See the usptream issue zmkfirmware#1494 for more. (I resolved this for my own build by incorporating the changes from zmkfirmware#1630.)