Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve Data #14

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Preserve Data #14

merged 2 commits into from
Sep 27, 2023

Conversation

momo-87
Copy link
Owner

@momo-87 momo-87 commented Sep 27, 2023

Update

  • Preserve clickedCity data in the local storage

@gitguardian
Copy link

gitguardian bot commented Sep 27, 2023

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8264987 OpenWeatherMap Token 304dfe5 src/redux/home/homeSlice.js View secret
8264987 OpenWeatherMap Token 304dfe5 src/redux/home/homeSlice.js View secret
8264987 OpenWeatherMap Token 304dfe5 src/redux/home/homeSlice.js View secret
8264987 OpenWeatherMap Token 304dfe5 src/redux/home/homeSlice.js View secret
8264987 OpenWeatherMap Token 304dfe5 src/redux/home/homeSlice.js View secret
8264987 OpenWeatherMap Token 304dfe5 src/redux/home/homeSlice.js View secret
8264987 OpenWeatherMap Token 304dfe5 src/redux/home/homeSlice.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@momo-87 momo-87 merged commit 2c88d87 into dev Sep 27, 2023
3 of 4 checks passed
@momo-87 momo-87 deleted the updates branch September 27, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant