Merge Dev Branch #6

momo-87 · 2023-07-01T18:31:22Z

Added Features:

Merge Dev Branch to main branch

…e Navbar

Project Setup

Fetch and Aisplay Data

Testing

change http to https

Add live version link to README.md file

zieeco

Hi @momo-87,

Great job so far! 👏
You've done well, however, there are some issues that you still need to work on to go to the next project, but you are almost there!

To highlight 🎯

No linter errors.✔️
Nice design. ✔️
Dice project implementation. ✔️
Good commit messages ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Check the comments under the review.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

zieeco · 2023-07-01T18:52:38Z

src/styles/navbar.scss

+    // ul {
+    //   display: flex;
+    //   height: 60px;
+
+    //   li a {
+    //   color: #F1F6F9;
+    //   }
+    // }


Please, kindly remove these commented pieces of code to make your codebase clean and maintainable

STYLES

Hey, according to the project requirement, you should use the correct font family as in the design. Please, kindly improve on this below:

Thank you, I really appreciate the time you spend reviewing my project.
Gill Sans and Lato font added to the project.

zieeco · 2023-07-01T19:00:43Z

src/components/OtherCitiesList.jsx

+import { addClickedCity } from 'redux/home/homeSlice';
+
+const OtherCitiesList = ({ otherCities, isLoading, error }) => {
+  // const { otherCities, isLoading, error } = useSelector(getData);


Please, kindly remove these commented pieces of code to make your codebase clean and maintainable

zieeco · 2023-07-01T19:11:11Z

src/redux/home/homeSlice.js

+      }
+    );
+  } catch (error) {
+    return rejectWithValue('Your Location is not supported !!');


[OPTIONAL]

Hey, at the start of your page, it throws the error for some specific country, e.g Nigeria, the app would throw that error, The app should be accessible to any country of the world and as such, please, kindly improve on this to make the app accessible to any country to improve the user experience of your app.

zieeco · 2023-07-01T19:11:30Z

src/redux/home/homeSlice.js

+      }
+    );
+  } catch (error) {
+    return rejectWithValue('Your Location is not supported !!');


[OPTIONAL]

Hey, at the start of your page, it throws the error for some specific country, e.g Nigeria, the app would throw that error, The app should be accessible to any country of the world and as such, please, kindly improve on this to make the app accessible to any country to improve the user experience of your app.

Unfortunately, the API provides the data so, I can manage this aspect. Thank you for your observation and feedback.

zieeco · 2023-07-01T19:22:04Z

README.md

+## 🚀 Live Demo <a name="live-demo"></a>
+>[Live Demo](https://airmetrics.onrender.com)


VIDEO PRESENTATION

Hey, great job adding the live demo version, however, you're yet to add the missing video presentation which is a key feature in this project to be approved. kindly see below the instructions to implement it below:

Thank you, I really appreciate the time you spend reviewing my project.
The video presentation link was added to the readme file.

zieeco · 2023-07-01T19:27:53Z

src/tests/App.test.js

+import '@testing-library/jest-dom';
+import React from 'react';
+import { render } from '@testing-library/react';
+import { MemoryRouter } from 'react-router-dom';
+import { Provider } from 'react-redux';
+import { configureStore } from '@reduxjs/toolkit';
+import data from './data';
+import App from '../App';
+
+const reducer = (
+  state = {
+    home: { home: data },
+  },
+) => state;
+
+const store = configureStore({ reducer });
+describe('App test', () => {
+  it('will test App rendering', () => {
+    render(
+      <MemoryRouter>
+        <Provider store={store}>
+          <App />
+        </Provider>
+      </MemoryRouter>,
+    );
+  });
+});


According to the project requirements :

The App should have unit tests for several components of the app and some pure functions in Redux code (currently you only tested the navbar component and App). The App should have integration tests using React Testing Library. Please, kindly add that 🙏

Thank you, I really appreciate the time you spend reviewing my project.
I added two additional tests for SelectedCity and DetailsPages respectively.

Review

Ghiftee

STATUS: CHANGES REQUIRED ♻️♻️

Hi there @momo-87 👋🏽 ,

Great work on making the changes requested by a previous reviewer 👏
To highlight 👍🏽
✔️ Tests are added
✔️ Tests pass
✔️ App runs as expected
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Ghiftee · 2023-07-01T21:41:09Z

src/tests/NearestCity.test.js

+import store from 'redux/store';
+import NearestCity from 'components/NearestCity';
+
+// eslint-disable-next-line react/prop-types


Kindly do not disable linters as it helps us write cleaner code

Ghiftee · 2023-07-01T21:44:05Z

src/tests/App.test.js

+const store = configureStore({ reducer });
+describe('App test', () => {
+  it('will test App rendering', () => {
+    render(
+      <MemoryRouter>
+        <Provider store={store}>
+          <App />
+        </Provider>
+      </MemoryRouter>,
+    );


[ OPTIONAL ] When I run the tests, I get a console error as shown below, I suggest that you consider fixing it. It is not enough for the tests to pass, but as good developers, we also need to pay attention to console errors.

Ghiftee · 2023-07-01T21:46:45Z

README.md

+
+## 🚀 Live Demo <a name="live-demo"></a>
+>[Live Demo](https://airmetrics.onrender.com)
+> [Video Presentation](https://www.loom.com/share/7d841e25e3ca4efd983da5fa5d90c2c2?sid=85dd4d9f-2734-4d6c-9233-d8c6a07ec87d)


Good job adding a video description of your project, however, you did not highlight a piece of code you are proud of as per the requirements shown below

Review2

Munsa1

Hi @momo-87,

In my opinion, your project is ready for the presentation! There is nothing else to say other than... it's time to merge it

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Merge pull request #6 from momo-87/dev

momo-87 added 30 commits June 24, 2023 11:09

Create React App

6da8c44

Cleanup the workspace

a1a1329

Install and configure react redux toolkits

1ef0f65

Add routing

452cdfc

Configure linters

b7a3ec5

Fix linter errors

532712c

Fix bug in from js.config.json file and remove NotMatch route from th…

b4ef664

…e Navbar

Merge pull request #1 from momo-87/project-setup

2896f77

Project Setup

Add home slice and fetch countries data

5621536

Render city data

f9e9216

Styling the main city section

cc56619

Get and render nearest city data

f947396

Get closest cities data

bbbdd4f

Fetch and render closest cities data

d2f12e0

Fix bugs

8f0808a

Add style to details page

8f64c69

Finilizing the details page style

c71d17f

Add icons

711a5ad

Add search input icon

60a68ae

Implement the search input field

962d40b

Implement the display of informations based on user input

74a8560

implement the callback when user display the detail page with not data

ee4c4b9

Fix linter errors

03d51d5

Merge pull request #2 from momo-87/fetch-and-display-data

b660f26

Fetch and Aisplay Data

Set the others cities list item to the same height

063bc7a

Implement testing for App.js component

1dd502f

Implement test for NearestCity Component

9bda1f4

Finalizing testing

8ca13a0

Update the README.md file

e5ea06d

Merge pull request #3 from momo-87/testing

3cfbd68

Testing

momo-87 added 4 commits July 1, 2023 19:14

change http to https

9d719f8

Merge pull request #4 from momo-87/testing

f69b1d9

change http to https

Add live version link to README.md file

ed82fbb

Merge pull request #5 from momo-87/testing

9efe731

Add live version link to README.md file

zieeco suggested changes Jul 1, 2023

View reviewed changes

momo-87 added 6 commits July 1, 2023 21:07

remove comments

767d64d

Add the design fonts and the video presentation

5e57011

Add test for SelectedCity component

6b66cff

Add test for SelectedCity component

2974dbe

Fix linter errors

4ac37a3

Merge pull request #7 from momo-87/review

07fe395

Review

Ghiftee suggested changes Jul 1, 2023

View reviewed changes

momo-87 added 3 commits July 1, 2023 23:08

Add link to Updated video presentation

6f3b36f

Enable linter in NearestCity.test.js file

ebaba88

Merge pull request #8 from momo-87/review2

33c6bc1

Review2

Munsa1 approved these changes Jul 1, 2023

View reviewed changes

momo-87 merged commit c5fada6 into main Jul 1, 2023
3 checks passed

momo-87 added a commit that referenced this pull request Jul 1, 2023

Merge pull request #9 from momo-87/main

8a413f5

Merge pull request #6 from momo-87/dev

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge Dev Branch #6

Merge Dev Branch #6

momo-87 commented Jul 1, 2023

zieeco left a comment

zieeco Jul 1, 2023

zieeco Jul 1, 2023

momo-87 Jul 1, 2023

zieeco Jul 1, 2023

zieeco Jul 1, 2023

zieeco Jul 1, 2023

momo-87 Jul 1, 2023

zieeco Jul 1, 2023

momo-87 Jul 1, 2023

zieeco Jul 1, 2023

momo-87 Jul 1, 2023

Ghiftee left a comment

Ghiftee Jul 1, 2023

Ghiftee Jul 1, 2023

Ghiftee Jul 1, 2023

Munsa1 left a comment

		## 🚀 Live Demo <a name="live-demo"></a>
		>[Live Demo](https://airmetrics.onrender.com)

Merge Dev Branch #6

Merge Dev Branch #6

Conversation

momo-87 commented Jul 1, 2023

Added Features:

zieeco left a comment

Choose a reason for hiding this comment

To highlight 🎯

Required Changes ♻️

Optional suggestions

Choose a reason for hiding this comment

Choose a reason for hiding this comment

STYLES

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VIDEO PRESENTATION

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ghiftee left a comment

Choose a reason for hiding this comment

STATUS: CHANGES REQUIRED ♻️♻️

Required Changes ♻️

Optional suggestions

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Munsa1 left a comment

Choose a reason for hiding this comment