Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ZMQ DaemonInfo [0.18 release] #9385

Open
wants to merge 1 commit into
base: release-v0.18
Choose a base branch
from
Open

Fix ZMQ DaemonInfo [0.18 release] #9385

wants to merge 1 commit into from

Conversation

vtnerd
Copy link
Contributor

@vtnerd vtnerd commented Jun 25, 2024

  • top_block_hash was never set in handler
  • wide_difficulty was never sent in JSON
  • wide_cumulative_difficulty was never sent in JSON

@vtnerd
Fix ZMQ DaemonInfo:
c5ad937 
  * top_block_hash was never set in handler
  * wide_difficulty was never sent in JSON
  * wide_cumulative_difficulty was never sent in JSON
@vtnerd
Copy link
Contributor Author

vtnerd commented Jun 25, 2024

Despite the failed tests, things look good. The macOS test requires a separate PR to fix Boost includes, and the test failure was the usual race_condition test that fails spuriously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
daemon pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vtnerd @selsta