This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
[SKUNK] Optimizations - Upgrade to Next13, reduce bundle size, fix security bug, etc. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report❌ An unexpected error occurred. For more details, check console
Test suite run success117 tests passing in 36 suites. Report generated by 🧪jest coverage report action from 6f8a628 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/components/truncate/index.js
Outdated
There was a problem hiding this comment.
pablosichert/react-truncate#153 - may be worth exploring this option to adding this file.
| @@ -23,7 +23,9 @@ import { | |||
| } from '../utils/seo'; | |||
| import { customCache } from '../utils/emotion'; | |||
|
|
|||
| import '../../mocks/run-msw'; | |||
| if (process.env.NEXT_PUBLIC_API_MOCKING === 'enabled') { | |||
There was a problem hiding this comment.
is this related to Nextjs upgrade ?
There was a problem hiding this comment.
No this is related to bundle size.
mcolella14
force-pushed
the
optimization
branch
from
6f8a628
to
a46c08f
Compare
Coverage report
Test suite run success117 tests passing in 36 suites. Report generated by 🧪jest coverage report action from a46c08f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on some optimizations during skunkworks. Wanted to make the client-side first-load js bundles smaller, but flora is not optimized for that. Still, the total bundle size now does not include the mocks, and we are on Next.js 13, which has a number of unstable features to help performance that we can leverage once they become stable.