Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5718): add ReadConcernMajorityNotAvailableYet to retryable errors #4154

Merged
merged 4 commits into from
Jun 25, 2024
Merged

feat(NODE-5718): add ReadConcernMajorityNotAvailableYet to retryable errors #4154

merged 4 commits into from
Jun 25, 2024

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented Jun 17, 2024 •
edited
Loading

Description

Add ReadConcernMajorityNotAvailableYet to retryable errors

What is changing?

See above.

Is there new documentation needed for these changes?

No, spec compliance.

What is the motivation for this change?

Spec compliance.

Release Highlight

Add ReadConcernMajorityNotAvailableYet to retryable errors

ReadConcernMajorityNotAvailableYet (error code 134) is now a retryable read error.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as draft June 17, 2024 20:32
@aditi-khare-mongoDB aditi-khare-mongoDB changed the title feat(NODE-5718): Add ReadConcernMajorityNotAvailableYet to retryable errors feat(NODE-5718): add ReadConcernMajorityNotAvailableYet to retryable errors Jun 17, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as ready for review June 17, 2024 20:55
@nbbeeken nbbeeken requested a review from durran June 20, 2024 15:43
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 20, 2024
@durran durran merged commit 4f32dec into main Jun 25, 2024
26 of 29 checks passed
@durran durran deleted the NODE-5718/add-retryable-error branch June 25, 2024 23:28
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 19, 2024
Open
@prernaadev01 prernaadev01 mentioned this pull request Jul 19, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Jul 19, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jul 19, 2024
Open
@lryanle lryanle mentioned this pull request Jul 19, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request Jul 19, 2024
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Jul 19, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Jul 19, 2024
Open
@lydmoon lydmoon mentioned this pull request Jul 19, 2024
Open
@mkusztal mkusztal mentioned this pull request Jul 19, 2024
Open
@brutussegun brutussegun mentioned this pull request Jul 19, 2024
Open
@akashkumar8115 akashkumar8115 mentioned this pull request Jul 20, 2024
Open
@tarun2001jawla tarun2001jawla mentioned this pull request Jul 20, 2024
Open
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Jul 20, 2024
Merged
@fettahogluhande fettahogluhande mentioned this pull request Jul 21, 2024
Open
@Pxntricia Pxntricia mentioned this pull request Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
3 participants
@aditi-khare-mongoDB @durran @nbbeeken