Uses precompile_utils from frontier
#2812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B7-runtimenoteworthy
RomarQ
requested review from
ahmadkaouk and
Agusrodri
and removed request for
a team
RomarQ
added
the
D5-nicetohaveaudit⚠️
Coverage Report@@ Coverage Diff @@
## master rq/move-precompile-utils +/- ##
============================================================
- Coverage 81.33% 81.11% -0.22%
- Files 301 274 -27
- Lines 85701 80598 -5103
============================================================
- Hits 69704 65375 -4329
- Misses 15997 15223 -774
|
librelois
reviewed
Jun 28, 2024
| /// System account size in bytes = Pallet_Name_Hash (16) + Storage_name_hash (16) + | ||
| /// Blake2_128Concat (16) + AccountId (20) + AccountInfo (4 + 12 + AccountData (4* 16)) = 148 | ||
| pub const SYSTEM_ACCOUNT_SIZE: u64 = 148; |
There was a problem hiding this comment.
Can you move this constant in crate primitives/account instead?
This way we can remove the precompile-common crate
librelois
approved these changes
Jun 28, 2024
Agusrodri
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #2427 by @rimbi
Uses precompile-utils from frontier