Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added face emotion game app #300

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

anabwan
Copy link
Contributor

@anabwan anabwan commented Sep 9, 2019

Signed-off-by: anabwan [email protected]

@nealvis
Copy link
Collaborator

nealvis commented Sep 9, 2019

For the networks that already have projects in the repository can you just use those (like ncappzoo/networks/face_detection_retail_0004) for networks that don't yet have projects in the repository can you create a project for them on a separate PR? (for the emotion network.) look at the face_detection_retail_0004 directory for an example makefile and a template for the network

@anabwan
Copy link
Contributor Author

anabwan commented Sep 10, 2019

sure, just pushed the code as backup.. I'm on it

@nealvis
Copy link
Collaborator

nealvis commented Sep 10, 2019

I like the game! A few suggestions.
Maybe add some text telling the user what todo like "match this emoji"
Maybe add some text telling the user what the emoji is. they were all obvious except the one that looked like it was crying. is the user supposed to cry? i could never match that one.
also maybe some text explaining how scoring is done. like hold the emoji for 5 seconds to score or something. i saw the timer counting down but not sure exactly how to score. if too much text on screen maybe could have hit "H" for help or something and then display the text.
Also would be nice to have a key like "q" for quiting.
looking forward to seeing this split up to network and app with makefiles so i can merge!

@anabwan
Copy link
Contributor Author

anabwan commented Sep 11, 2019

I added all the things that you suggested.
I'm on the readme and makefiles

@anabwan
Copy link
Contributor Author

anabwan commented Sep 15, 2019

@nealvis can you please review, it's ready for merge

@tomevang
Copy link
Collaborator

tomevang commented Oct 2, 2019

I think this PR can be closed.

@anabwan
Copy link
Contributor Author

anabwan commented Oct 3, 2019

I think this PR can be closed.

This is the game file!! not a network which include a basic program..

anabwan added 8 commits October 23, 2019 09:16
Signed-off-by: anabwan <[email protected]>
Signed-off-by: anabwan <[email protected]>
Signed-off-by: anabwan <[email protected]>
t

Signed-off-by: anabwan <[email protected]>
Signed-off-by: anabwan <[email protected]>
Signed-off-by: anabwan <[email protected]>
Signed-off-by: anabwan <[email protected]>
Signed-off-by: anabwan <[email protected]>
@DrewBearly DrewBearly added the app label Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants