Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.1.6 #19

Merged
merged 3 commits into from
Dec 17, 2018
Merged

v0.1.6 #19

merged 3 commits into from
Dec 17, 2018

Conversation

ajvb
Copy link
Contributor

@ajvb ajvb commented Dec 14, 2018 •
edited
Loading

  • verbose logging option
  • return reputation scores in iprepd error cases or when the IP
    is not found.
  • Submit metrics for all connection error cases

@ajvb
v0.1.6
432c294 
* verbose logging option
* return reputation scores in iprepd error cases or when the IP
is not found.
milescrabill
milescrabill approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@milescrabill milescrabill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the logic change to cache_errors seems sound

ameihm0912
ameihm0912 approved these changes Dec 17, 2018
View reviewed changes
lib/resty/iprepd.lua Outdated
local reputation = self:get_reputation(ip)
if reputation then
self:debug_log("Got reputation of " .. reputation .. " for " .. ip)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using string.format is much faster than concat'ing strings if there are multiple elements to combine, but it's probably not a big deal for debug output.

@ajvb ajvb merged commit 92137ee into master Dec 17, 2018
@ajvb ajvb deleted the ajvb/v0.1.6 branch December 17, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milescrabill milescrabill milescrabill approved these changes

@ameihm0912 ameihm0912 ameihm0912 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajvb @milescrabill @ameihm0912