0.1.7 #21
Merged
0.1.7 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameihm0912
approved these changes
Jan 15, 2019
milescrabill
suggested changes
Jan 17, 2019
| if err then | ||
| if self.statsd then | ||
| self.statsd.incr("iprepd.err." .. err) | ||
| if string.find(err, " ") then | ||
| if string.find(err, "could not be resolved") and string.find(err, "Operation timed out") then |
There was a problem hiding this comment.
We should log the else condition cases (errors with spaces in them that are not DNS or timeouts)
milescrabill
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dont_blockvariable with the less confusingblocking_mode. Also makes it off by default.iprepd.status.acceptedis always set when a request is not blocked.iprepd.get_reputation)iprepd.err.dns_timeout)cc: @milescrabill - Will need to swap the "blocking enabled" variables in cloudops-infra back to what you had them at :)