Define the Security Considerations of the publisher's actions #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The publisher tool operates in four stages, and not in a transaction, which raises concerns as to what happens when it does not update in a consistent way.
The possibilities are:
In practice, we can choose between the second and third bullet by choosing which sign-off occurs first, as if it fails, then the second also will not happen. Right now, the Filter tries to update first, so the third option can be practically discounted, pending code changes.
The initial draft text I have here concerns the second option, what happens if the client does not observe intermediate metadata changes, but does obtain an updated filter that assumes knowledge of those metadata changes.
This is a WIP PR for now, as a place to discuss the issue.