Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: refactore extend expression #30

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Conversation

mrLSD
Copy link
Owner

@mrLSD mrLSD commented Mar 25, 2024

Description

💾 Refactored Extend Expression with improved instructions generation results.
Rethinking design for ExtendExpression AST, and SemanticContext instructions for extended expressions. Previously it was different logic categories. And it was pitfalls, as it was practically difficult to generate efficient Instructions for SemanticContext related on AST. ⚠️ this PR is solved this to bring things in the same logic categories, and now SemanticContext for stack instructions is fully flexible for ExtendedExpression AST.

➡️ Added tests for extended expressions and SemanticStackContext instructions for it
➡️ Extended (README)[README.md] documentation
➡️ Refactored AST to add generic type for ExtendedExpression instructions
➡️ Extended clippy to new Rust requirements

@mrLSD mrLSD added documentation Improvements or additions to documentation enhancement New feature or request tests Tests implementations and coverage labels Mar 25, 2024
@mrLSD mrLSD self-assigned this Mar 25, 2024
@mrLSD mrLSD added this to the v0.4.1 milestone Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fb7afaa) to head (acf80b8).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1956      1964    +8     
=========================================
+ Hits          1956      1964    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrLSD mrLSD merged commit 76126a5 into master Mar 26, 2024
4 checks passed
@mrLSD mrLSD deleted the feat/refactore-extend-expression branch March 26, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request tests Tests implementations and coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant