-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regenerator-runtime as a polyfill for async/await #20761
Conversation
nice! async/await here we come |
b4859f0
to
aa9b7e8
Compare
aa9b7e8
to
e677e95
Compare
Thanks! |
Hello all,
Looking at the build since r125, we can see the following:
The problematic line seems to live here (commented it out to verify): e677e95#diff-ae80df62f9f5c7165b96cece03e3ad2dc1e16b90770c9d59683eabc1b529d9eeR280 fwiw the three.module.js build doesn't have this issue. Does anyone have recommendations of how to move forward with a fix here? Migrating to use the three.module.js is viable (but high effort), and ultimately doesn't solve the core issue with the other build. |
If I use |
@arikwex it's an issue with babel and your current setup, what tools are you using? Adding |
Thanks for that @marcofugaro. We're using brunch js. Your suggestion to add |
Related issue: #20754 (comment)
Description
regenerator-runtime is also needed to polyfill async/await for IE11. It's a dependency which babel doesn't include by default. More details about this procedure in this guide.
I added the library as a poyfill and used the
@rollup/plugin-node-resolve
plugin to import it directly from node_modules.✅ I tested the new build with the PR #20754 and it fixes the issue with
misc_legacy
.