Support new arch #185
Merged
Support new arch #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
force-pushed
the
@janic/new-arch
branch
9 times, most recently
from
ed058ee
to
8057c35
Compare
janicduplessis
force-pushed
the
@janic/new-arch
branch
2 times, most recently
from
8c4d17c
to
a0b3e5d
Compare
janicduplessis
force-pushed
the
@janic/new-arch
branch
from
a0b3e5d
to
cca9d77
Compare
mrousavy
approved these changes
Jan 29, 2024
|
|
||
| @objc var resizeMode: NSString { | ||
| get { | ||
| convertContentMode(resizeMode: blurhashView.contentMode) |
There was a problem hiding this comment.
We could simply extend the ContentMode type to add a jsValue or stringRepresentation or something like that - but let's leave it like this for now.
Comment on lines
+107
to
+120
| private final func convertResizeMode(resizeMode: NSString) -> ContentMode { | ||
| switch resizeMode { | ||
| case "contain": | ||
| return .scaleAspectFit | ||
| case "cover": | ||
| return .scaleAspectFill | ||
| case "stretch": | ||
| return .scaleToFill | ||
| case "center": | ||
| return .center | ||
| default: | ||
| return .scaleAspectFill | ||
| } | ||
| } |
There was a problem hiding this comment.
Could also be a convenience init instead of a separate func here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the example app to RN 0.73 then adds support for new arch. I did a best effort at keeping backwards compat but it might introduce some issues with older RN version, could use more testing.