Skip to content

Commit

Permalink
[core] Update Node.js version to v18 on CircleCI, CodeSandbox, and Ne…
Browse files Browse the repository at this point in the history
…tlify (#37173)

Co-authored-by: Michał Dudak <[email protected]>
  • Loading branch information
ZeeshanTamboli and michaldudak committed Jun 9, 2023
1 parent 43c2736 commit ff1124e
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ defaults: &defaults
AWS_REGION_ARTIFACTS: eu-central-1
working_directory: /tmp/material-ui
docker:
- image: cimg/node:14.21
- image: cimg/node:18.16

# CircleCI has disabled the cache across forks for security reasons.
# Following their official statement, it was a quick solution, they
Expand Down Expand Up @@ -672,7 +672,7 @@ jobs:
DANGER_COMMAND: prepareBundleSizeReport
- run:
name: build @mui packages
command: yarn lerna run --ignore @mui/icons-material --parallel --scope "@mui/*" build
command: yarn lerna run --ignore @mui/icons-material --concurrency 8 --scope "@mui/*" build
- run:
name: create @mui/material canary distributable
command: |
Expand Down
2 changes: 1 addition & 1 deletion .codesandbox/ci.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"buildCommand": "build:codesandbox",
"installCommand": "install:codesandbox",
"node": "14",
"node": "18",
"packages": [
"packages/mui-material",
"packages/mui-codemod",
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
command = "yarn docs:build && yarn docs:export"

[build.environment]
NODE_VERSION = "14"
NODE_VERSION = "18"
# Not using `playwright` when building docs.
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD = "1"

Expand Down
14 changes: 12 additions & 2 deletions packages/mui-material-next/src/Tabs/Tabs.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,21 @@ describe('<Tabs />', () => {

nodeEnv = process.env.NODE_ENV;
// We can't use a regular assignment, because it causes a syntax error in Karma
Object.defineProperty(process.env, 'NODE_ENV', { value: 'development' });
Object.defineProperty(process.env, 'NODE_ENV', {
value: 'development',
configurable: true,
writable: true,
enumerable: true,
});
});

after(() => {
Object.defineProperty(process.env, 'NODE_ENV', { value: nodeEnv });
Object.defineProperty(process.env, 'NODE_ENV', {
value: nodeEnv,
configurable: true,
writable: true,
enumerable: true,
});
});

it('should warn if a Tab has display: none', () => {
Expand Down
14 changes: 12 additions & 2 deletions packages/mui-material/src/Tabs/Tabs.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -375,11 +375,21 @@ describe('<Tabs />', () => {

nodeEnv = process.env.NODE_ENV;
// We can't use a regular assignment, because it causes a syntax error in Karma
Object.defineProperty(process.env, 'NODE_ENV', { value: 'development' });
Object.defineProperty(process.env, 'NODE_ENV', {
value: 'development',
configurable: true,
writable: true,
enumerable: true,
});
});

after(() => {
Object.defineProperty(process.env, 'NODE_ENV', { value: nodeEnv });
Object.defineProperty(process.env, 'NODE_ENV', {
value: nodeEnv,
configurable: true,
writable: true,
enumerable: true,
});
});

it('should warn if a `Tab` has display: none', function test() {
Expand Down

0 comments on commit ff1124e

Please sign in to comment.